-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LASzip] Bump to also generate Mac M1 builds #5345
Conversation
In particular, see point 2 |
L/LASzip/build_tarballs.jl
Outdated
@@ -3,7 +3,7 @@ | |||
using BinaryBuilder, Pkg | |||
|
|||
name = "LASzip" | |||
version = v"3.4.3" | |||
version = v"3.4.3-1.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh, no, you have to stick to X.Y.Z
only. I guess I'm going to prohibit anything else completely, since this is just the second attempt in one day: #5344 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for making you sigh 😓. I was wondering how to "break" away from following the exact version of the underlying library. I will set it to `v"3.4.3000" for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a PkgVersion (pv"1.2.3"
) or similar to enforce such things?
No description provided.